[Snyk] Fix for 1 vulnerabilities#5314
Closed
snyk-io[bot] wants to merge 1 commit intomasterfrom
Closed
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-TARFS-10293725
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Reviewer's GuideThis PR patches a high-severity TarFS vulnerability by upgrading key Backstage dependencies in the permission-node plugin to specific, fixed versions. Sequence Diagram: Snyk Automated Vulnerability Fix ProcesssequenceDiagram
actor SnykAutomation as "Snyk Automation"
participant ProjectRepo as "Project Repository"
participant PackageFile as "plugins/permission-node/package.json"
participant VulnerabilityDB as "Snyk Vulnerability DB"
SnykAutomation->>ProjectRepo: Scan project dependencies
SnykAutomation->>VulnerabilityDB: Check dependencies against database
VulnerabilityDB-->>SnykAutomation: Report vulnerability (e.g., SNYK-JS-TARFS-10293725)
SnykAutomation->>PackageFile: Identify affected dependencies in package.json
SnykAutomation->>PackageFile: Update versions to fixed versions:
Note over PackageFile: @backstage/backend-common: workspace:^ -> 0.24.1
Note over PackageFile: @backstage/backend-plugin-api: workspace:^ -> 0.6.19
Note over PackageFile: @backstage/plugin-auth-node: workspace:^ -> 0.5.0
SnykAutomation->>ProjectRepo: Commit updated package.json
SnykAutomation->>ProjectRepo: Create Pull Request for review
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Author
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) |
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
+51
to
+55
| "@backstage/backend-common": "0.24.1", | ||
| "@backstage/backend-plugin-api": "0.6.19", | ||
| "@backstage/config": "workspace:^", | ||
| "@backstage/errors": "workspace:^", | ||
| "@backstage/plugin-auth-node": "workspace:^", | ||
| "@backstage/plugin-auth-node": "0.5.0", |
There was a problem hiding this comment.
The dependency management approach in this PR creates inconsistency by changing only some @backstage dependencies from workspace:^ to specific versions while leaving others with workspace references. This mixed approach can cause dependency resolution issues in monorepo setups.
For proper dependency management, either:
- Keep all
@backstagedependencies asworkspace:^references (preferred for monorepo development) - Change all to specific versions
The current mixed approach may lead to version conflicts or unexpected behavior when resolving dependencies. Consider standardizing the approach across all @backstage dependencies in this file.
Suggested change
| "@backstage/backend-common": "0.24.1", | |
| "@backstage/backend-plugin-api": "0.6.19", | |
| "@backstage/config": "workspace:^", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/plugin-auth-node": "workspace:^", | |
| "@backstage/plugin-auth-node": "0.5.0", | |
| "@backstage/backend-common": "workspace:^", | |
| "@backstage/backend-plugin-api": "workspace:^", | |
| "@backstage/config": "workspace:^", | |
| "@backstage/errors": "workspace:^", | |
| "@backstage/plugin-auth-node": "workspace:^", |
Spotted by Diamond
Is this helpful? React 👍 or 👎 to let us know.
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
plugins/permission-node/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-TARFS-10293725
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Improper Link Resolution Before File Access ('Link Following')
Summary by Sourcery
Fix a high-severity tar-fs vulnerability by updating key backstage dependencies in the permission-node plugin
Bug Fixes:
Enhancements: